Add figsize handler for plot_probegroup#350
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
=======================================
Coverage 89.75% 89.76%
=======================================
Files 12 12
Lines 1972 1973 +1
=======================================
+ Hits 1770 1771 +1
Misses 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alejoe91
requested changes
May 24, 2025
|
|
||
| import matplotlib.pyplot as plt | ||
|
|
||
| figsize = kargs.pop("figsize", None) |
Member
There was a problem hiding this comment.
I think that pop fails if figsize is not in the dict. Can you use get instead?
Member
There was a problem hiding this comment.
Actually you're passing the None, so this works!
alejoe91
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's hard to change the figsize if same_axes=False in plot_probegroup without changing the default parameters, so this is my suggestion